ENH: Improved threadsafe messaging #1340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
…puteArrayHistogramByFeature.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
imikejackson
force-pushed
the
feature/threadsafe_messaging
branch
from
c0db31d to
11cba58
Compare
Is that chunk thread safe? Because it is getting called from multiple threads. |
imikejackson
requested changes
Jun 25, 2025
...ationAnalysis/src/OrientationAnalysis/Filters/Algorithms/ComputeKernelAvgMisorientations.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jared Duffey <[email protected]>
Yes. An atomic variable is used to store the total progress, and the actual messaging is thread safe using spdlog. And the other data stored inside ProgressMessenger is not shared so there is not issue. |
Signed-off-by: Jared Duffey <[email protected]>
* Fixed progress message template doc comment Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ComputeArrayHistogramByFeature.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jared Duffey <[email protected]>
JDuffeyBQ
force-pushed
the
feature/threadsafe_messaging
branch
from
e97bca8 to
b636836
Compare
Signed-off-by: Jared Duffey <[email protected]>
JDuffeyBQ
force-pushed
the
feature/threadsafe_messaging
branch
from
b636836 to
5ba58ee
Compare
* Now use thread pool specifically for filter messaging instead of spdlog's global pool Signed-off-by: Jared Duffey <[email protected]>
imikejackson
approved these changes
Jun 30, 2025
nyoungbq
pushed a commit
to nyoungbq/simplnx
that referenced
this pull request
Jul 18, 2025
* Updated vcpkg with spdlog Signed-off-by: Jared Duffey <[email protected]> * Added spdlog to cmake Signed-off-by: Jared Duffey <[email protected]> * Changed IFilter::MessageHandler to move string Signed-off-by: Jared Duffey <[email protected]> * Added MessageHelper Signed-off-by: Jared Duffey <[email protected]> * Updated filters Signed-off-by: Jared Duffey <[email protected]> * Fixed formatting Signed-off-by: Jared Duffey <[email protected]> * Fixed missing override Signed-off-by: Jared Duffey <[email protected]> * Fixed incomplete type error on gcc/clang Signed-off-by: Jared Duffey <[email protected]> * Fixed incorrect parameter Signed-off-by: Jared Duffey <[email protected]> * Update src/Plugins/SimplnxCore/src/SimplnxCore/Filters/Algorithms/ComputeArrayHistogramByFeature.cpp Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Added doc comments Signed-off-by: Jared Duffey <[email protected]> * Added ThrottleSink to further reduce message output Signed-off-by: Jared Duffey <[email protected]> * Switched percent calculation to return float32 * Fixed progress message template doc comment Signed-off-by: Jared Duffey <[email protected]> * Let thread pool persist for multiple filters Signed-off-by: Jared Duffey <[email protected]> * Fixed formatting Signed-off-by: Jared Duffey <[email protected]> * Fixed shadowing on gcc Signed-off-by: Jared Duffey <[email protected]> * Fixed thread pool race condition * Now use thread pool specifically for filter messaging instead of spdlog's global pool Signed-off-by: Jared Duffey <[email protected]> --------- Signed-off-by: Jared Duffey <[email protected]> Co-authored-by: Michael Jackson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to spdlog for processing messages from filters on a separate thread